On 5/21/2012 4:28 PM, Dave Hansen wrote: > When called for anonymous (non-shared) mappings, > hugetlb_reserve_pages() does a resv_map_alloc(). It depends on > code in hugetlbfs's vm_ops->close() to release that allocation. > > However, in the mmap() failure path, we do a plain unmap_region() > without the remove_vma() which actually calls vm_ops->close(). > > This is a decent fix. This leak could get reintroduced if > new code (say, after hugetlb_reserve_pages() in > hugetlbfs_file_mmap()) decides to return an error. But, I think > it would have to unroll the reservation anyway. > > This hasn't been extensively tested. Pretty much compile and > boot tested along with Christoph's test case: > > http://marc.info/?l=linux-mm&m=133728900729735 > > Signed-off-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> > Acked-by: Mel Gorman <mel@xxxxxxxxx> > ecked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> typo. ;-) > Reported/tested-by: Christoph Lameter <cl@xxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>