On 05/21/2012 10:13 PM, Christoph Lameter wrote:
So unless I am missing something, it seems to me the correct code would be:
>
> s->refcount--;
> if (!s->refcount)
> return kmem_cache_close;
> return 0;
>
> And while we're on that, that makes the sequence list_del() -> if it fails ->
> list_add() in the common kmem_cache_destroy a bit clumsy. Aliases will be
> re-added to the list quite frequently. Not that it is a big problem, but
> still...
True but this is just an intermediate step. Ultimately the series will
move sysfs processing into slab_common.c and then this is going away.
But until then, people bisecting into this patch will find a broken
state, right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>