Re: [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio

["zhangpeng (AS)" <zhangpeng362@xxxxxxxxxx>]

On 2023/7/17 21:48, Matthew Wilcox wrote:

> On Mon, Jul 17, 2023 at 09:26:01PM +0800, Peng Zhang wrote:
> > -static inline void count_swpout_vm_event(struct page *page)
> > +static inline void count_swpout_vm_event(struct folio *folio)
> >   {
> >   #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > -	if (unlikely(PageTransHuge(page)))
> > +	if (unlikely(folio_test_large(folio)))
> >   		count_vm_event(THP_SWPOUT);
> >   #endif
> Since this is a THP_SWPOUT event, we should do this as:
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -	if (unlikely(PageTransHuge(page)))
> +	if (folio_test_pmd_mappable(folio))
> 		count_vm_event(THP_SWPOUT);
> -#endif

Agreed. I'll convert PageTransHuge to folio_test_pmd_mappable.

--
Best Regards,
Peng