On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote: > smatch reports > mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' > was not declared. Should it be static? > mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' > was not declared. Should it be static? > > These variables are only used in their defining file, so it should be static. These are functions, not variables, and you're the third person to send this patch today.