On Tue, Jul 11, 2023 at 10:52:02AM -0700, Nhat Pham wrote: > On Mon, Jul 10, 2023 at 10:18 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > On Mon, Jul 10, 2023 at 03:16:56PM -0700, Minchan Kim wrote: > > > This patchset uses frontswap for zram swap usecase and remove > > > swap_slot_free_notify swap specific operation in block device. > > > It shows 13% swapout improvement for MADV_PAGEOUT. > > > > Err, no. frontswap needs to go away, and not be tried to a block > > driver. If you want compressed swap without a block driver please use > > zswap and help improvig it and the swap abstraction to not require > > a backing allocation for it. > > > > We need to fix swap and not pile hacks on top of hacks. > > > > +1. Based on earlier discussions, it seems like the agreed upon way forward > is to remove the frontswap interface: > > https://lore.kernel.org/linux-mm/20230530235447.GB102494@xxxxxxxxxxx/ Thanks for feedback. Understood. I also agree frontswap is hack so let me this patchset. I hope swap abstraction goes to the way Chris Li suggested in the end.