On Fri, Jul 7, 2023 at 8:03 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Fri, Jul 07, 2023 at 10:00:42PM +0200, Markus Elfring wrote: > > … > > > write-locked to prevent page faults into the VMA being expanded. Add > > > the necessary locking. > > > > 1. Would it a bit nicer to put the second sentence on a separate line > > in such a change description? Maybe. Will do if there is a need to post a v2. > > > > 2. I noticed that you put the address “stable@xxxxxxxxxxxxxxx” > > into the message field “Cc”. > > Would you like to specify such a hint as a tag? > > > > See also: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n264 Yeah, I always forget that :( > > > > 3. How do you think about to add the tag “Fixes”? I thought about it but was not sure which patch I should list under such tag because the rules for stack expansion changed recently. > > > > 4. Will a cover letter become helpful also for the presented small patch series? Not much to say other than "add some missing locking" :) > > Markus, your nitpicking is not useful. Please stop. I'll fix the nits, at least the ones I can, if there is a need for v2.
