Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 6, 2023 at 9:11 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> On Thu, Jul 6, 2023 at 7:27 AM Holger Hoffstätte
> <holger@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On 2023-07-06 00:55, Suren Baghdasaryan wrote:
> > > On Wed, Jul 5, 2023 at 3:37 PM Holger Hoffstätte
> > > <holger@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> > >>> Jiri, Holger, would you be able to try
> > >>> https://lore.kernel.org/all/20230705171213.2843068-2-surenb@xxxxxxxxxx/
> > >>> and see if your issues still exist?
> > >>
> > >> Just in time! Not 2 minutes ago I finished rebuilding 6.4.2 + the last version of
> > >> your patches on a second machine (old Intel Sandy Bridge workstation) to be my
> > >> crash test dummy. I removed the BROKEN dependency in mm/Kconfig, manually set
> > >> PER_VMA_LOCK=y and ... it seems to work?! Boots fine, Firefox seems to work
> > >> (but no exhaustive tests yet). I will also rerun a few reboot laps, just to
> > >> exercise this a bit harder and see if something comes up.
> > >>
> > >> Tomorrow I'll also try again on my Zen2 Thinkpad and will report back.
> > >>
> > >> Fingers crossed!
> > >
> > > Thanks! This is promising.
> >
> > Indeed it was, and still is. :)
> >
> > This morning I wrangled 6.4.2 + v4 of the patches into all my machines,
> > enabled PER_VMA_LOCK=y, removed BROKEN and so far everything has been humming
> > along just fine. One machine has been compiling for several hours without issue.
> > My Zen2 thinkpad - which was previously really unhappy with enabled PER_VMA_LOCK -
> > has booted a few times without hiccup, and Firefox has been happily roaming the
> > interwebs for several hours as well. \o/
>
> This is great! Thanks so much for verifying!
> Andrew, if it's not too late, maybe we can drop the BROKEN dependency
> now that we have this confirmation?

Liam pointed me to another possible issue with per-VMA locks due to
the recent changes in stack expansion locking rules. So, it's probably
safer to keep it marked BROKEN. I'll post a simple fix for that
shortly.

>
> >
> > cheers
> > Holger





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux