Re: [PATCH] lib: Remove repeated “initialization” in check_state_handling()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Would the information “test_maple_tree: …” be more appropriate
for the subsystem specification in the patch subject?


> The original code initializes 'entry'
> twice in line 3229 and 3232, which
> causes duplicate initialization issue.
> To fix this, we remove the initialization
> of 'entry' in line 3229.

* Why did you choose 41 characters as a line length maximum
  for your change description?

* Would you like to achieve reconsiderations of implementation details
  by other means than patches?

* How do you think about to clarify the usage of affected variable
  assignments better?

* What does hinder you to take any requirements from the Linux development
  documentation better into account?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4

Regards,
Markus





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux