Re: [PATCH v2 2/4] mm/memory: convert wp_page_shared() to use folios

[Matthew Wilcox <willy@xxxxxxxxxxxxx>]

On Wed, Jul 05, 2023 at 12:43:33PM -0700, Sidhartha Kumar wrote:
> @@ -3375,7 +3375,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf)
>  		 */
>  		if (!vmf->page)
>  			return wp_pfn_shared(vmf);
> -		return wp_page_shared(vmf);
> +		return wp_page_shared(vmf, page_folio(vmf->page));
>  	}
>  
>  	if (vmf->page)

I was actually hoping you'd move:

        if (vmf->page)
                folio = page_folio(vmf->page);

up to immediately after the call to vm_normal_page(), and avoid even
this call to page_folio().