On Tue, Jul 4, 2023 at 1:18 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi Suren, > > Thank you for your patch. > > On 7/3/23 20:21, Suren Baghdasaryan wrote: > > A memory corruption was reported in [1] with bisection pointing to the > > patch [2] enabling per-VMA locks for x86. > > Disable per-VMA locks config to prevent this issue while the problem is > > being investigated. This is expected to be a temporary measure. > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@xxxxxxxxxx > > > > Reported-by: Jiri Slaby <jirislaby@xxxxxxxxxx> > > Reported-by: Jacob Young <jacobly.alt@xxxxxxxxx> > > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > --- > > mm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 09130434e30d..de94b2497600 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -1224,7 +1224,7 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > > def_bool n > > > > config PER_VMA_LOCK > > - def_bool y > > + bool "Enable per-vma locking during page fault handling." > > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > > help > > Allow per-vma locking during page fault handling. > > > This does not disable the option it only makes it user selectable > and for users with an existing .config which already has this > it changes nothing. Hmm. Yes, I didn't think about a case when kernel would be updated and .config would not... > > IMHO you should add a "depends on BROKEN" here until this is fixed, > so that this really gets disabled. Agree, that would be a sure way to disable it. I'll use it if the proper fix still does not work. Thanks! > > Or maybe just revert 0bff0aaea03e2a3ed6bfa302155cca8a432a1829 > for now? That would disable it only for x86 while keeping it for all other supported platforms, so we would have to revert several patches. I wanted the simplest way to temporarily disable the feature until a fix is in place. Let me test it a bit and if that works I'll send patches to fix and re-enable CONFIG_PER_VMA_LOCK instead of disabling it. Thanks, Suren. > > Regards, > > Hans > >
