On 05/17/2012 02:11 AM, Seth Jennings wrote: > On 05/15/2012 09:05 PM, Minchan Kim wrote: > >> Exactly saying, [zram|zcache] should has a dependency with >> zsmalloc, not x86. So replace x86 dependeny with ZSMALLOC. >> >> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> >> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> >> --- >> drivers/staging/zcache/Kconfig | 3 +-- >> drivers/staging/zram/Kconfig | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig >> index 7048e01..ceb7f28 100644 >> --- a/drivers/staging/zcache/Kconfig >> +++ b/drivers/staging/zcache/Kconfig >> @@ -2,8 +2,7 @@ config ZCACHE >> bool "Dynamic compression of swap pages and clean pagecache pages" >> # X86 dependency is because zsmalloc uses non-portable pte/tlb >> # functions >> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86 >> - select ZSMALLOC >> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && ZSMALLOC > > > Sorry Minchan, I should have said this the first time around. I ran > into this issue before with CRYTPO vs CRYPTO=y. ZCACHE is a bool where > ZSMALLOC is a tristate. It is not sufficient for ZSMALLOC to be set; it > _must_ be builtin, otherwise you get linker errors. > > The dependency should be ZSMALLOC=y. Sigh. I should have been more careful. Thanks. I will fix it in next spin. > > Thanks, > Seth > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>