Re: [EXT] Re: [linux-next:master 5324/12162] drivers/cpufreq/cpufreq-dt-platdev.c:18:34: warning: unused variable 'allowlist'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28-06-23, 08:39, Nathan Chancellor wrote:
> On Wed, Jun 28, 2023 at 01:33:40AM +0000, Zhipeng Wang wrote:
> > Hi,
> > 
> > I'm sorry for responding so late. I have also tried to reproduce this issue many times and I have not reproduced it.
> 
> I can reproduce this with the configuration that the robot provided,
> even with GCC.
> 
>   $ curl -LSso .config https://download.01.org/0day-ci/archive/20230625/202306250025.savpMM8L-lkp@xxxxxxxxx/config
> 
>   $ make -skj"$(nproc)" ARCH=i386 CROSS_COMPILE=x86_64-linux- W=1 olddefconfig drivers/cpufreq/cpufreq-dt-platdev.o
>   drivers/cpufreq/cpufreq-dt-platdev.c:105:34: warning: 'blocklist' defined but not used [-Wunused-const-variable=]
>     102 | static const struct of_device_id blocklist[] __initconst = {
>         |                                  ^~~~~~~~~
>   drivers/cpufreq/cpufreq-dt-platdev.c:18:34: warning: 'allowlist' defined but not used [-Wunused-const-variable=]
>      17 | static const struct of_device_id allowlist[] __initconst = {
>         |                                  ^~~~~~~~~
> 
> The W=1 is the key here, this warning is not enabled in a normal build. This
> configuration does not have CONFIG_OF=y, so of_match_node() is just defined as
> NULL, meaning these variables are indeed unused.

Ahh. Sent a patch to fix it now. Thanks.

> However, I am kind of confused as to how the robot landed on 3b062a08698 as the
> problematic commit, as I can reproduce these warnings without it.

Right.

-- 
viresh




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux