On Tue, Jun 27, 2023 at 10:37:58PM +0000, "Huang, Kai" <kai.huang@xxxxxxxxx> wrote: > > > > > > +/* > > > + * Do the module global initialization if not done yet. > > > + * It's always called with interrupts and preemption disabled. > > > + */ > > > > If interrupts are always disabled why do you need _irqsave()? > > > > I'll remove the _irqsave(). > > AFAICT Isaku preferred this for additional security, but this is not necessary. It's because the lockdep complains. Anyway, it's save to remove _irqsave as discussed with you. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
