Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/27/23 14:46, Dinh Nguyen wrote:


On 6/27/23 16:01, Guenter Roeck wrote:
On 6/27/23 13:05, Dinh Nguyen wrote:


On 6/27/23 14:56, Vishal Moola wrote:
On Tue, Jun 27, 2023 at 12:14 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

On 6/27/23 12:10, Guenter Roeck wrote:
On 6/27/23 10:42, Vishal Moola wrote:
On Mon, Jun 26, 2023 at 10:47 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote:
Part of the conversions to replace pgtable constructor/destructors with
ptdesc equivalents.

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@xxxxxxxxx>
Acked-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>

This patch causes all nios2 builds to fail.

It looks like you tried to apply this patch on its own. This patch depends
on patches 01-12 of this patchset to compile properly. I've cross-compiled
this architecture and it worked, but let me know if something fails
when its applied on top of those patches (or the rest of the patchset).


No, I did not try to apply this patch on its own. I tried to build yesterday's
pending-fixes branch of linux-next.


A quick check shows that the build fails with next-20230627. See log below.

Ah it looks like this one slipped into -next on its own somehow? Stephen, please
drop this patch from -next; it shouldn't be in without the rest of the
patchset which
I intend to have Andrew take through the mm tree.


I apologize, but I queue this patch up for Linus and it's been pulled for this merge window. I didn't realize you were going to take this patchset through another tree.

Sorry about that.


Yes, indeed, I just confirmed that all nios2 builds in the mainline kernel
are now broken.


Please let me know if you need to do anything. I'm going to out for a week starting tomorrow.


Not sure I understand. It seems to me that it would have to be you to do something.
After all, you are the nios2 maintainer, and nios2 builds in mainline are now
broken. Maybe send a revert ? Am I missing something ?

Guenter





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux