On Mon, Jun 26, 2023 at 09:23:17PM -0700, Suren Baghdasaryan wrote: > Change folio_lock_or_retry to accept vm_fault struct and return the > vm_fault_t directly. This will be used later to return additional > information about the state of the mmap_lock upon return from this > function. > > Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> The patch looks all fine to me except on the renaming.. *_fault() makes me think of a fault handler, while *_lock_or_retry() was there for years and it still sounds better than the new one to me. Can we still come up with a better renaming, or just keep the name? Thanks, -- Peter Xu
