On Mon, 2023-06-26 at 14:21 -0700, Sathyanarayanan Kuppuswamy wrote: > > + /* All '0's are just unused parameters. */ > > I have noticed that you add the above comment whenever you call seamcall() > with > 0 as parameters. Is this a ask from the maintainer? If not, I think you can > skip > it. Just explaining the parameters in seamcall function definition is good > enough. Yes I followed maintainer (I didn't bother to find the exact link this time, though). I think in this way we don't need to go to TDX module spec to check whether 0 has meaning in each SEAMCALL, especially in code review. I kinda agree having them in multiple places is a little bit noisy, but I don't have a better way.
