Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Subject: Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
From: Michal Hocko <mhocko@xxxxxxxx>
Date: Fri, 23 Jun 2023 11:21:01 +0200
Cc: Petr Mladek <pmladek@xxxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, "Luis Claudio R. Goncalves" <lgoncalv@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, John Ogness <john.ogness@xxxxxxxxxxxxx>
In-reply-to: <20230623081250.h20rlLik@linutronix.de>
References: <20230621104034.HT6QnNkQ@linutronix.de> <0e9fc992-8e05-2e63-b3b1-d8d3ce89fc16@I-love.SAKURA.ne.jp> <20230621130641.-5iueY1I@linutronix.de> <dd7e0df5-a6c1-adef-af16-c0cf3a8aee65@I-love.SAKURA.ne.jp> <20230621143421.BgHjJklo@linutronix.de> <ZJMZWxDrkV3M1EQH@alley> <20230623081250.h20rlLik@linutronix.de>

On Fri 23-06-23 10:12:50, Sebastian Andrzej Siewior wrote:
[...]
> It would do _but_ is it really needed? All users but one (the one in
> __build_all_zonelists()) have interrupts already disabled. This isn't a
> hot path and is not used very common. Does it justify the ifdef?

This is not my call of course but let me just stress out that if all
that is just because of __build_all_zonelists then it is likely not
really worth it. We are talking about memory hoptlug here. I seriously
doubt that this is something anybody would be using with RT
expectations.
-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Sebastian Andrzej Siewior

References:
- [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Sebastian Andrzej Siewior
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Tetsuo Handa
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Sebastian Andrzej Siewior
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Tetsuo Handa
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Sebastian Andrzej Siewior
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Petr Mladek
- Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
  - From: Sebastian Andrzej Siewior

Prev by Date: Re: [PATCH net-next v3 01/18] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES)
Next by Date: Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
Previous by thread: Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
Next by thread: Re: [PATCH] mm/page_alloc: Use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]