(2012/05/15 3:00), Johannes Weiner wrote: > Before piling more things (reclaim stats) on top of the current mess, > I thought it'd be better to clean up a bit. > > The biggest change is printing statistics directly from live counters, > it has always been annoying to declare a new counter in two separate > enums and corresponding name string arrays. After this series we are > down to one of each. > > mm/memcontrol.c | 223 +++++++++++++++++------------------------------ > 1 file changed, 82 insertions(+), 141 deletions(-) > to all 1-6. Thank you. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> One excuse for my old implementation of mem_cgroup_get_total_stat(), which is fixed in patch 6, is that I thought it's better to touch all counters in a cachineline at once and avoiding long distance for-each loop. What number of performance difference with some big hierarchy(100+children) tree ? (But I agree your code is cleaner. I'm just curious.) Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>