(2012/05/15 5:09), Tejun Heo wrote: > On Fri, May 11, 2012 at 06:53:08PM +0900, KAMEZAWA Hiroyuki wrote: >> I picked this up from Costa's slub memcg series. For fixing added warning >> by patch 4. >> == >> From: Glauber Costa <glommer@xxxxxxxxxxxxx> >> Subject: [PATCH 6/6] remove __must_check for res_counter_charge_nofail() >> >> Since we will succeed with the allocation no matter what, there >> isn't the need to use __must_check with it. It can very well >> be optional. >> >> Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx> >> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > For 3-6, > > Reviewed-by: Tejun Heo <tj@xxxxxxxxxx> > > Thanks a lot for doing this. This doesn't solve all the failure paths > tho. ie. what about -EINTR failures from lock contention? > pre_destroy() would probably need delay and retry logic with > WARN_ON_ONCE() on !-EINTR failures. > Yes, I'll do more work. I tend to split series, sorry. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>