On 6/19/23 05:52, David Hildenbrand wrote: >> + /* >> + * SEAMCALL caused #GP or #UD. By reaching here %eax contains >> + * the trap number. Convert the trap number to the TDX error >> + * code by setting TDX_SW_ERROR to the high 32-bits of %rax. >> + * >> + * Note cannot OR TDX_SW_ERROR directly to %rax as OR instruction >> + * only accepts 32-bit immediate at most. > > Not sure if that comment is really helpful here. It's a common pattern > for large immediates, no? It's a question of whether you write the comments for folks that read x86 assembly all the time or not. I think the comment is helpful.
