On Fri, May 11, 2012 at 05:16:09PM +0800, Gavin Shan wrote: > While allocateing pages using buddy allocator, the compound page > is probably split up to free pages. Under the circumstance, the > compound page should be destroied by function destroy_compound_page(). > However, there has duplicate check to judge if the page is compound > one. > > The patch removes the duplicate check since the function compound_order() > will returns 0 while the page hasn't PG_head set in function destroy_compound_page(). > That's to say, the function destroy_compound_page() needn't check > PG_head any more through function PageHead(). > > Signed-off-by: Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx> Looks good! But the slab in the subject suggests it would not affect other parts of mm, while it actually affects THP, too. Should probably be removed? Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>