Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Huang, Kai" <kai.huang@xxxxxxxxx>
Subject: Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
From: "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>
Date: Mon, 19 Jun 2023 17:56:22 +0300
Cc: "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "nik.borisov@xxxxxxxx" <nik.borisov@xxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "Hansen, Dave" <dave.hansen@xxxxxxxxx>, "david@xxxxxxxxxx" <david@xxxxxxxxxx>, "bagasdotme@xxxxxxxxx" <bagasdotme@xxxxxxxxx>, "ak@xxxxxxxxxxxxxxx" <ak@xxxxxxxxxxxxxxx>, "Wysocki, Rafael J" <rafael.j.wysocki@xxxxxxxxx>, "Chatre, Reinette" <reinette.chatre@xxxxxxxxx>, "Christopherson,, Sean" <seanjc@xxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "Yamahata, Isaku" <isaku.yamahata@xxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "Luck, Tony" <tony.luck@xxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "Shahar, Sagi" <sagis@xxxxxxxxxx>, "imammedo@xxxxxxxxxx" <imammedo@xxxxxxxxxx>, "Gao, Chao" <chao.gao@xxxxxxxxx>, "Brown, Len" <len.brown@xxxxxxxxx>, "sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx" <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>, "Huang, Ying" <ying.huang@xxxxxxxxx>, "Williams, Dan J" <dan.j.williams@xxxxxxxxx>
In-reply-to: <a60acb9be5bd5b0eb9b32ff11932fc019262dfe0.camel@intel.com>
References: <cover.1685887183.git.kai.huang@intel.com> <30358db4eff961c69783bbd4d9f3e50932a9a759.1685887183.git.kai.huang@intel.com> <49bd9f7f-9a2b-8b8c-f408-49b9b5982eb7@suse.com> <a60acb9be5bd5b0eb9b32ff11932fc019262dfe0.camel@intel.com>

On Thu, Jun 15, 2023 at 10:24:17PM +0000, Huang, Kai wrote:
> Hi Kirill/Dave,
> 
> Since I have received couple of tags from you, may I know which way do you
> prefer?

I agree with Nikolay, removing these "if (ret)" helps readability.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

Follow-Ups:
- Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
  - From: Huang, Kai

References:
- [PATCH v11 00/20] TDX host kernel support
  - From: Kai Huang
- [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
  - From: Kai Huang
- Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
  - From: Nikolay Borisov
- Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
  - From: Huang, Kai

Prev by Date: Re: [PATCH v11 18/20] x86: Handle TDX erratum to reset TDX private memory during kexec() and reboot
Next by Date: [syzbot] [mm?] linux-next boot error: kernel BUG in do_vmi_align_munmap
Previous by thread: Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
Next by thread: Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]