On 06/14/23 11:51, Peter Xu wrote: > On Wed, Jun 14, 2023 at 05:47:31PM +0200, David Hildenbrand wrote: > > Right. Then just call patch #2 "Add missing write-permission check" and this > > patch "Support FOLL_PIN in hugetlb_follow_page_mask()" or sth. like that. > > > > Regarding the backport, I really wonder if patch #2 is required at all, > > because I didn't sport any applicable FOLL_WRITE users. Maybe there were > > some? Hm. If it's not applicable, a single "Support FOLL_PIN in > > hugetlb_follow_page_mask()" patch might be cleanest. > > Yeah, I agree. The code is definitely needed, not the split of patches if > no need for a backport. Let me merge then. > Should have read this before adding my RB to patch 2. I assumed no backport. Agree, than merging the gup_must_unshare here makes more sense. -- Mike Kravetz
