[linux-next:master 8650/9793] security/apparmor/policy_unpack.c:1144: warning: expecting prototype for verify_dfa_accept_xindex(). Prototype was for verify_dfa_accept_index() instead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b16049b21162bb649cdd8519642a35972b7910fe
commit: bd1f4873db0451a3f004062f9ca09a978605943a [8650/9793] apparmor: fix profile verification and enable it
config: i386-randconfig-i001-20230614 (https://download.01.org/0day-ci/archive/20230614/202306141934.UKmM9bFX-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bd1f4873db0451a3f004062f9ca09a978605943a
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout bd1f4873db0451a3f004062f9ca09a978605943a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash security/apparmor/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306141934.UKmM9bFX-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   security/apparmor/policy_unpack.c:1144: warning: Function parameter or member 'table_size' not described in 'verify_dfa_accept_index'
>> security/apparmor/policy_unpack.c:1144: warning: expecting prototype for verify_dfa_accept_xindex(). Prototype was for verify_dfa_accept_index() instead


vim +1144 security/apparmor/policy_unpack.c

736ec752d95e91 John Johansen 2010-07-29  1137  
bd1f4873db0451 John Johansen 2023-04-17  1138  /**
bd1f4873db0451 John Johansen 2023-04-17  1139   * verify_dfa_accept_xindex - verify accept indexes are in range of perms table
bd1f4873db0451 John Johansen 2023-04-17  1140   * @dfa: the dfa to check accept indexes are in range
bd1f4873db0451 John Johansen 2023-04-17  1141   * table_size: the permission table size the indexes should be within
bd1f4873db0451 John Johansen 2023-04-17  1142   */
bd1f4873db0451 John Johansen 2023-04-17  1143  static bool verify_dfa_accept_index(struct aa_dfa *dfa, int table_size)
736ec752d95e91 John Johansen 2010-07-29 @1144  {
736ec752d95e91 John Johansen 2010-07-29  1145  	int i;
736ec752d95e91 John Johansen 2010-07-29  1146  	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
bd1f4873db0451 John Johansen 2023-04-17  1147  		if (ACCEPT_TABLE(dfa)[i] >= table_size)
e37986097ba63c Zou Wei       2020-04-28  1148  			return false;
736ec752d95e91 John Johansen 2010-07-29  1149  	}
e37986097ba63c Zou Wei       2020-04-28  1150  	return true;
736ec752d95e91 John Johansen 2010-07-29  1151  }
736ec752d95e91 John Johansen 2010-07-29  1152  

:::::: The code at line 1144 was first introduced by commit
:::::: 736ec752d95e91e77cc0e8c97c057ab076ac2f51 AppArmor: policy routines for loading and unpacking policy

:::::: TO: John Johansen <john.johansen@xxxxxxxxxxxxx>
:::::: CC: James Morris <jmorris@xxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux