On Tue, 2023-06-13 at 13:18 +0300, kirill.shutemov@xxxxxxxxxxxxxxx wrote:
> On Mon, Jun 12, 2023 at 10:10:39PM +0000, Huang, Kai wrote:
> > On Mon, 2023-06-12 at 17:33 +0300, kirill.shutemov@xxxxxxxxxxxxxxx wrote:
> > > On Mon, Jun 12, 2023 at 02:33:58AM +0000, Huang, Kai wrote:
> > > >
> > > > >
> > > > > Maybe not even a pr_warn(), but something that's a bit ominous and has a
> > > > > chance of getting users to act.
> > > >
> > > > Sorry I am not sure how to do. Could you give some suggestion?
> > >
> > > Maybe something like this would do?
> > >
> > > I'm struggle with the warning message. Any suggestion is welcome.
> >
> > I guess it would be helpful to print out the actual consumed TDMRs?
> >
> > pr_warn("consumed TDMRs reaching limit: %d used (out of %d)\n",
> > tdmr_idx, tdmr_list->max_tdmrs);
>
> It is off-by-one. It supposed to be tdmr_idx + 1.
>
In your code, yes. Thanks for pointing out. I copied it from my code.
