Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED
From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 13 Jun 2023 22:33:47 +0100
Cc: dhowells@xxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, oe-lkp@xxxxxxxxxxxxxxx, lkp@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <f50b438f-90bc-36b1-c943-18d7a4b3f441@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <f50b438f-90bc-36b1-c943-18d7a4b3f441@redhat.com> <431929.1686588681@warthog.procyon.org.uk>

Okay, it isn't this.  The problem appears to be that __blockdev_direct_IO()
calls dio_cleanup() twice if do_direct_IO() fails.

David

References:
- Re: [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED
  - From: David Hildenbrand
- [PATCH] block: Fix dio_bio_alloc() to set BIO_PAGE_PINNED
  - From: David Howells