On Mon, 12 Jun 2023 12:01:20 +0200 David Hildenbrand <david@xxxxxxxxxx> wrote: > ... > > >> > >> If it's a performance improvement, it would be good to show that it is > >> an actual improvement worth the churn ... > > Sorry for the confusion. As for the OOM issue, the previous > > commit(https://lkml.kernel.org/r/1683782550-25799-1-git-send-email-zhaoyang.huang@xxxxxxxxxx) > > helps to decrease the fail rate from 12/20 to 2/20, which it turn to > > be 0 when applying this patch. > > Thanks! Can we make that clearer in the patch description? I'm > struggling a bit my self to find the right words. > > Something like > > "This change further decreases the chance for wrong OOMs in the presence > of a lot of CMA memory." > Great, I added that. > > In any case > > Acked-by: David Hildenbrand <david@xxxxxxxxxx> > And I'll move this patch into mm-stable.