On 6/9/23 23:55, Andrew Morton wrote: > On Mon, 24 Apr 2023 05:54:59 +0200 Oscar Salvador <osalvador@xxxxxxx> wrote: > >> > Given that no other stackdepot user needs these counters, maybe it >> > should be cleaner to store an opaque struct along with the stack, >> > passing its size to stack_depot_save(), and letting users access it >> > directly using the stackdepot handler. >> > >> > I am also wondering if a separate hashtable mapping handlers to >> > counters would solve the problem for you? >> >> Let us see first if with the changes from above the code gets to a more >> generic and clean stage, if not we can explore further options. > > Alexander, does this approach sound reasonable to you? Note this is a v4 thread; there was (and the version in mm-unstable is) v5, where the latest was Alexander requesting further changes: https://lore.kernel.org/all/CAG_fn%3DUJgnLFGgpkXbMeD6axZN_ifEPHvWpy2_oiPyG1a6PXng@xxxxxxxxxxxxxx/ > The overall feature seems useful, although I'm not seeing any positive > reviewer feedback.
