On 06/09/23 at 10:10am, John Paul Adrian Glaubitz wrote: > Hello Baoquan! > > On Fri, 2023-06-09 at 15:55 +0800, Baoquan He wrote: > > Also add macro definitions for port|mm io functions since SuperH > > has its own implementation in arch/sh/kernel/iomap.c and > > arch/sh/include/asm/io_noioport.h. These will conflict with the port|mm io > > function definitions in include/asm-generic/io.h to cause compiling > > errors like below: > > What change does the "Also" refer to? It refers to these kind of macro definitions, this place and those in other several places. Please correct me if I misused the expression to cause confusion. +#define ioread8 ioread8 +#define ioread16 ioread16 +#define ioread16be ioread16be +#define ioread32 ioread32 +#define ioread32be ioread32be + +#define iowrite8 iowrite8 +#define iowrite16 iowrite16 +#define iowrite16be iowrite16be +#define iowrite32 iowrite32 +#define iowrite32be iowrite32be + +#define ioread8_rep ioread8_rep +#define ioread16_rep ioread16_rep +#define ioread32_rep ioread32_rep + +#define iowrite8_rep iowrite8_rep +#define iowrite16_rep iowrite16_rep +#define iowrite32_rep iowrite32_rep