[linux-next:master 4146/8065] drivers/leds/leds-cht-wcove.c:142:21: warning: no previous prototype for 'cht_wc_leds_brightness_get'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yauhen,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   db10f126048021b86e43a5d6a335ec49dec10155
commit: 047da762b9a937d60c16e2c8392c326e5ab11a1d [4146/8065] leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230608/202306082341.UQtCM8PO-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=047da762b9a937d60c16e2c8392c326e5ab11a1d
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 047da762b9a937d60c16e2c8392c326e5ab11a1d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306082341.UQtCM8PO-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/leds/leds-cht-wcove.c:142:21: warning: no previous prototype for 'cht_wc_leds_brightness_get' [-Wmissing-prototypes]
     142 | enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/cht_wc_leds_brightness_get +142 drivers/leds/leds-cht-wcove.c

   141	
 > 142	enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
   143	{
   144		struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
   145		unsigned int val;
   146		int ret;
   147	
   148		mutex_lock(&led->mutex);
   149	
   150		ret = regmap_read(led->regmap, led->regs->ctrl, &val);
   151		if (ret < 0) {
   152			dev_err(cdev->dev, "Failed to read LED CTRL reg: %d\n", ret);
   153			ret = 0;
   154			goto done;
   155		}
   156	
   157		val &= led->regs->on_off_mask;
   158		if (val != led->regs->on_val) {
   159			ret = 0;
   160			goto done;
   161		}
   162	
   163		ret = regmap_read(led->regmap, led->regs->pwm, &val);
   164		if (ret < 0) {
   165			dev_err(cdev->dev, "Failed to read LED PWM reg: %d\n", ret);
   166			ret = 0;
   167			goto done;
   168		}
   169	
   170		ret = val;
   171	done:
   172		mutex_unlock(&led->mutex);
   173	
   174		return ret;
   175	}
   176	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux