On 6/7/23 15:56, Huang, Kai wrote: > It's not just for the "BIOS buggy" case. The main purpose is to give an error > message when the caller mistakenly calls tdx_enable(). It's also OK to oops when there's a kernel bug, aka. caller mistake. > Also, now the machine check handler improvement patch also calls SEAMCALL to get > a given page's page type. It's totally legal that a machine check happens when > the CPU isn't in VMX operation (e.g. KVM isn't loaded), and in fact we use the > SEAMCALL return value to detect whether CPU is in VMX operation and handles such > case accordingly. Listen, I didn't say there wasn't a reason for it. I said that this patch lacked the justification. So, stop throwing things at the wall, pick the *REAL* reason, and go rewrite the patch, please.
