Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Subject: Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 07 Jun 2023 18:10:05 +0100
Cc: dhowells@xxxxxxxxxx, axboe@xxxxxxxxx, borisp@xxxxxxxxxx, chuck.lever@xxxxxxxxxx, cong.wang@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, dsahern@xxxxxxxxxx, edumazet@xxxxxxxxxx, john.fastabend@xxxxxxxxx, kuba@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, pabeni@xxxxxxxxxx, tom@xxxxxxxxxxxxxxx, tom@xxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, willemdebruijn.kernel@xxxxxxxxx, willy@xxxxxxxxxxxxx
In-reply-to: <20230607160528.20078-1-kuniyu@amazon.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <20230607160528.20078-1-kuniyu@amazon.com> <20230607140559.2263470-10-dhowells@redhat.com>

Kuniyuki Iwashima <kuniyu@xxxxxxxxxx> wrote:

> > +	if (skb_queue_empty(&sk->sk_write_queue))
> 
> nit: would be better to use skb_queue_empty_lockless().

Ok.

David

References:
- Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush
  - From: Kuniyuki Iwashima
- [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush
  - From: David Howells

Prev by Date: Re: [PATCH net-next v5 06/14] tls/device: Use splice_eof() to flush
Next by Date: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES
Previous by thread: Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush
Next by thread: [PATCH net-next v5 13/14] tls/device: Support MSG_SPLICE_PAGES
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]