Re: [linux-next:master 2368/6966] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiri,

On Mon, 2023-06-05 at 23:00 +0200, Jiri Olsa wrote:
> On Mon, Jun 05, 2023 at 09:04:21AM +0200, Jiri Olsa wrote:
> > On Mon, Jun 05, 2023 at 01:50:10PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   bc708bbd8260ee4eb3428b0109f5f3be661fae46
> > > commit: 65eb006d85a2ac0b23464808099726bd826e9877 [2368/6966] bpf: Move kernel test kfuncs to bpf_testmod
> > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > > reproduce:
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=65eb006d85a2ac0b23464808099726bd826e9877
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 65eb006d85a2ac0b23464808099726bd826e9877
> > >         make O=/tmp/kselftest headers
> > >         make O=/tmp/kselftest -C tools/testing/selftests
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202306051319.EihCQZPs-lkp@xxxxxxxxx/
> > > 
> > > All warnings (new ones prefixed by >>):
> > > 
> > >    tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:199:1: warning: no previous prototype for 'bpf_testmod_test_read' [-Wmissing-prototypes]
> > >      199 | bpf_testmod_test_read(struct file *file, struct kobject *kobj,
> > >          | ^~~~~~~~~~~~~~~~~~~~~
> > >    tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:259:1: warning: no previous prototype for 'bpf_testmod_test_write' [-Wmissing-prototypes]
> > >      259 | bpf_testmod_test_write(struct file *file, struct kobject *kobj,
> > >          | ^~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset' [-Wmissing-prototypes]
> > >      330 | __bpf_kfunc void bpf_kfunc_call_test_offset(struct prog_test_ref_kfunc *p)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:336:1: warning: no previous prototype for 'bpf_kfunc_call_memb_acquire' [-Wmissing-prototypes]
> > >      336 | bpf_kfunc_call_memb_acquire(void)
> > >          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:342:18: warning: no previous prototype for 'bpf_kfunc_call_memb1_release' [-Wmissing-prototypes]
> > >      342 | __bpf_kfunc void bpf_kfunc_call_memb1_release(struct prog_test_member1 *p)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:394:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail1' [-Wmissing-prototypes]
> > >      394 | __bpf_kfunc void bpf_kfunc_call_test_fail1(struct prog_test_fail1 *p)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:398:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail2' [-Wmissing-prototypes]
> > >      398 | __bpf_kfunc void bpf_kfunc_call_test_fail2(struct prog_test_fail2 *p)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:402:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail3' [-Wmissing-prototypes]
> > >      402 | __bpf_kfunc void bpf_kfunc_call_test_fail3(struct prog_test_fail3 *p)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:410:18: warning: no previous prototype for 'bpf_kfunc_call_test_mem_len_fail1' [-Wmissing-prototypes]
> > >      410 | __bpf_kfunc void bpf_kfunc_call_test_mem_len_fail1(void *mem, int len)
> > >          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >    tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:465:14: warning: no previous prototype for 'bpf_fentry_shadow_test' [-Wmissing-prototypes]
> > >      465 | noinline int bpf_fentry_shadow_test(int a)
> > >          |              ^~~~~~~~~~~~~~~~~~~~~~
> > 
> > hi,
> > I can't reprduce, not event the old warnings..
> > is there perhaps specific .config you use for the kernel?
> 
> ah ok, just make W=1 will do that

Sorry, the steps to reproduce are obsolete in our report.

Yes we do "make W=1" build and it produces the missing-prototypes
warnings. There is also a similar case in a previous report [1]

[1] https://lore.kernel.org/oe-kbuild-all/ZC6h%2Fb2N%2Fu%2Fd4XbT@krava/

We've updated the hints to be more accurate in bot's report. Sorry for
any inconvenience.

--
Best Regards,
Yujie


> I think we can add most of them to bpf_testmod_kfunc.h
> will send patch
> 
> jirka
> 





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux