On Fri, May 11, 2012 at 01:01:09AM -0400, David Miller wrote: > From: Mel Gorman <mgorman@xxxxxxx> > Date: Thu, 10 May 2012 14:45:05 +0100 > > > +/** > > + * propagate_pfmemalloc_skb - Propagate pfmemalloc if skb is allocated after RX page > > + * @page: The page that was allocated from netdev_alloc_page > > + * @skb: The skb that may need pfmemalloc set > > + */ > > +static inline void propagate_pfmemalloc_skb(struct page *page, > > + struct sk_buff *skb) > > Please use consistent prefixes in the names for new interfaces. > Understood. > This one should probably be named "skb_propagate_pfmemalloc()" and > go into skbuff.h since it needs no knowledge of netdevices. > I used a netdev prefix and placed it in skbuff.h which was stupid. The screw-up was because I was partially reverting a patch that deleted netdev_alloc_page but I didn't need any device information so the naming was poor. I renamed netdev_alloc_page to skb_alloc_page and will fix up the documentation appropriately. Thanks. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>