On 2023/5/31 6:13, Andrew Morton wrote: > On Sat, 27 May 2023 18:07:28 +0800 Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote: > >> Remove some unneeded header files. No functional change intended. >> >> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> >> --- >> mm/page_alloc.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index e671c747892f..beb6db613238 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -24,9 +24,7 @@ >> #include <linux/kernel.h> >> #include <linux/kasan.h> >> #include <linux/kmsan.h> >> -#include <linux/module.h> > > This contains the prototype for print_modules(). So we're now reliant > upon module.h being included via some other header, which is fragile. Will keep it. > >> #include <linux/suspend.h> >> -#include <linux/pagevec.h> >> #include <linux/ratelimit.h> >> #include <linux/oom.h> >> #include <linux/topology.h> >> @@ -36,8 +34,6 @@ >> #include <linux/memory_hotplug.h> >> #include <linux/nodemask.h> >> #include <linux/vmstat.h> >> -#include <linux/sort.h> >> -#include <linux/pfn.h> >> #include <linux/fault-inject.h> >> #include <linux/compaction.h> >> #include <trace/events/kmem.h> >> @@ -52,11 +48,9 @@ >> #include <linux/memcontrol.h> >> #include <linux/ftrace.h> >> #include <linux/lockdep.h> >> -#include <linux/nmi.h> >> #include <linux/psi.h> >> #include <linux/khugepaged.h> >> #include <linux/delayacct.h> >> -#include <asm/div64.h> > > Needed for do_div()? Will add it back. Depending on "asm/div64.h" being included via some other headers is fragile too. Many thanks for your comment.
