On Fri, Jun 02, 2023 at 06:42:59PM +0800, Baoquan He wrote: > On 06/01/23 at 04:13am, Christoph Hellwig wrote: > > On Tue, May 30, 2023 at 05:37:23PM +0800, Baoquan He wrote: > > > If we want to consolidate code, we can move is_ioremap_addr() to > > > include/linux/mm.h libe below. Not sure if it's fine. With it, > > > both kernel/iomem.c and mm/ioremap.c can use is_ioremap_addr(). > > > > Can we just add a ne header for this given that no one else really > > needs it? > > Is it OK like below? Looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>