On 5/30/2023 3:27 PM, Vlastimil Babka wrote:
On 5/25/23 14:53, Baolin Wang wrote:
The caller has validated the page before calling pdate_pageblock_skip(),
^ u
Ah, sorry for typos. And I see Andrew has already helped to correct this
typo. Thanks Andrew :)
thus drop the redundant page validation in update_pageblock_skip().
Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
Thanks for your reviewing.
---
mm/compaction.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 163e2ec70aff..426bb6ce070b 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -436,9 +436,6 @@ static void update_pageblock_skip(struct compact_control *cc,
if (cc->no_set_skip_hint)
return;
- if (!page)
- return;
-
set_pageblock_skip(page);
/* Update where async and sync compaction should restart */
