On 2023/5/27 18:32, Mike Rapoport wrote:
Hi Kefeng,
On Fri, May 26, 2023 at 08:05:05PM +0800, Kefeng Wang wrote:
There are two interfaces to show the memblock information, memblock_dump_all()
and /sys/kernel/debug/memblock/, but the content is displayed separately,
let's unify them in case of more different changes over time.
I don't see much value in this unifications, especially as it must change
the format of one of the dumps. Although these are not ABIs, keeping the
existing formats seems more important to me that having a single dump
function.
As the debugfs show is similar to memblock_dump, but not exactly the
same, eg,the node info and flag(with/without name), we may want to
support flagname in memblock_dump, also avoid more different changes
in the future. but keep single dump function is fine since they are
not complicated:)
