On Fri, May 26, 2023 at 02:54:12PM +0100, Matthew Wilcox wrote: > On Fri, May 26, 2023 at 12:55:44AM -0700, Luis Chamberlain wrote: > > This is an initial attempt to add support for block size > PAGE_SIZE for tmpfs. > > Why would you want this? It helps us experiment with higher order folio uses > > with fs APIS and helps us test out corner cases which would likely need > > to be accounted for sooner or later if and when filesystems enable support > > for this. Better review early and burn early than continue on in the wrong > > direction so looking for early feedback. > > I think this is entirely the wrong direction to go in. Any recommendations for alternative directions? > You're coming at this from a block layer perspective, and we have two > ways of doing large block devices -- qemu nvme and brd. tmpfs should > be like other filesystems and opportunistically use folios of whatever > size makes sense. I figured the backing block size would be a good reason to use high order folios for filesystems, and this mimicks that through the super block block size. Although usage of the block size would be moved to the block device and tmpfs use an page order, what other alternatives were you thinking? Luis
