Re: [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>, "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>, "agk@xxxxxxxxxx" <agk@xxxxxxxxxx>, "snitzer@xxxxxxxxxx" <snitzer@xxxxxxxxxx>, "philipp.reisner@xxxxxxxxxx" <philipp.reisner@xxxxxxxxxx>, "lars.ellenberg@xxxxxxxxxx" <lars.ellenberg@xxxxxxxxxx>, "christoph.boehmwalder@xxxxxxxxxx" <christoph.boehmwalder@xxxxxxxxxx>, "hch@xxxxxxxxxxxxx" <hch@xxxxxxxxxxxxx>, "djwong@xxxxxxxxxx" <djwong@xxxxxxxxxx>, "minchan@xxxxxxxxxx" <minchan@xxxxxxxxxx>, "senozhatsky@xxxxxxxxxxxx" <senozhatsky@xxxxxxxxxxxx>
Subject: Re: [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT
From: Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx>
Date: Fri, 26 May 2023 09:24:14 +0000
Accept-language: en-US
Cc: "patches@xxxxxxxxxxxxxxx" <patches@xxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "linux-xfs@xxxxxxxxxxxxxxx" <linux-xfs@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx" <drbd-dev@xxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "willy@xxxxxxxxxxxxx" <willy@xxxxxxxxxxxxx>, "hare@xxxxxxx" <hare@xxxxxxx>, "p.raghav@xxxxxxxxxxx" <p.raghav@xxxxxxxxxxx>, "da.gomez@xxxxxxxxxxx" <da.gomez@xxxxxxxxxxx>, "rohan.puri@xxxxxxxxxxx" <rohan.puri@xxxxxxxxxxx>, "rpuri.linux@xxxxxxxxx" <rpuri.linux@xxxxxxxxx>, "kbusch@xxxxxxxxxx" <kbusch@xxxxxxxxxx>
In-reply-to: <20230526073336.344543-6-mcgrof@kernel.org>
References: <20230526073336.344543-1-mcgrof@kernel.org> <20230526073336.344543-6-mcgrof@kernel.org>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0
Wdcipoutbound: EOP-TRUE

On 26.05.23 09:34, Luis Chamberlain wrote:
> +	u32 index = bio->bi_iter.bi_sector >> PAGE_SECTORS_SHIFT;
> +	u32 offset = (bio->bi_iter.bi_sector & (PAGE_SECTORS - 1)) <<
>  			SECTOR_SHIFT;

(PAGE_SECTORS - 1) is SECTOR_MASK, please use this.

Thanks,
	Johannes

References:
- [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT
  - From: Luis Chamberlain
- [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT
  - From: Luis Chamberlain

Prev by Date: Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages()
Next by Date: Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages()
Previous by thread: [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT
Next by thread: Re: [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]