On Thu, May 25, 2023 at 09:38:57AM +0100, David Howells wrote: > > Call zonefs_io_error() after getting any error from filemap_splice_read() > in zonefs_file_splice_read(), including non-fatal errors such as ENOMEM, > EINTR and EAGAIN. > > Suggested-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > Link: https://lore.kernel.org/r/5d327bed-b532-ad3b-a211-52ad0a3e276a@xxxxxxxxxx/ This seems like a bizarre thing to do. Let's suppose you got an -ENOMEM. blkdev_report_zones() is also likely to report -ENOMEM in that case, which will cause a zonefs_err() to be called. Surely that can't be the desired outcome from getting -ENOMEM!