Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 24 May 2023 14:56:47 -0700
Cc: david@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, hch@xxxxxx, patches@xxxxxxxxxxxxxxx, linux-modules@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, pmladek@xxxxxxxx, petr.pavlu@xxxxxxxx, prarit@xxxxxxxxxx, lennart@xxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, song@xxxxxxxxxx, lucas.de.marchi@xxxxxxxxx, lucas.demarchi@xxxxxxxxx, christophe.leroy@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, rppt@xxxxxxxxxx, dave@xxxxxxxxxxxx, willy@xxxxxxxxxxxxx, vbabka@xxxxxxx, mhocko@xxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, colin.i.king@xxxxxxxxx, jim.cromie@xxxxxxxxx, catalin.marinas@xxxxxxx, jbaron@xxxxxxxxxx, rick.p.edgecombe@xxxxxxxxx, yujie.liu@xxxxxxxxx
In-reply-to: <CAHk-=wjahcAqLYm0ijcAVcPcQAz-UUuJ3Ubx4GzP_SJAupf=qQ@mail.gmail.com>
References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-2-mcgrof@kernel.org> <CAHk-=wjahcAqLYm0ijcAVcPcQAz-UUuJ3Ubx4GzP_SJAupf=qQ@mail.gmail.com>

On Wed, May 24, 2023 at 2:52 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Stop adding horrific code for some made-up load that isn't real.

Even if you trigger some "worst case 3x memory use", that is
_temporary_, and will be free'd in the end.

The patches to "fix" this are worse than the disease.

                  Linus

Follow-Ups:
- Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
  - From: Luis Chamberlain

References:
- [PATCH 0/2] module: avoid all memory pressure due to duplicates
  - From: Luis Chamberlain
- [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
  - From: Luis Chamberlain
- Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
  - From: Linus Torvalds

Prev by Date: Re: [PATCH 0/9] Mitigate a vmap lock contention
Next by Date: Re: [PATCH 27/31] mm/khugepaged: allow pte_offset_map[_lock]() to fail
Previous by thread: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
Next by thread: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]