On Mon 22-05-23 11:48:52, Linus Torvalds wrote: > On Mon, May 22, 2023 at 11:39 AM David Rientjes <rientjes@xxxxxxxxxx> wrote: > > > > I think VM_BUG_ON*() and friends are used to crash the kernel for > > debugging so that we get a crash dump and because some variants don't > > exist for VM_WARN_ON(). > > I do think that from a VM developer standpoint, I think it should be > fine to just effectively turn VM_BUG_ON() into WARN_ON_ONCE() together > with panic_on_warn. This is a very good idea. VM_BUG_ON has always been rather special and from my past experience people are not really sure when to use it. It is a conditional thing so it cannot be really used for really BUG_ON cases. Turning them into VM_WARN (not sure about ONCE) makes a lot of sense because as you say you can make them panic easily. -- Michal Hocko SUSE Labs
