Re: [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hugh Dickins <hughd@xxxxxxxxxx>
Subject: Re: [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail
From: Yu Zhao <yuzhao@xxxxxxxxxx>
Date: Sun, 21 May 2023 23:26:46 -0600
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>, Yang Shi <shy828301@xxxxxxxxx>, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Alistair Popple <apopple@xxxxxxxxxx>, Ralph Campbell <rcampbell@xxxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Steven Price <steven.price@xxxxxxx>, SeongJae Park <sj@xxxxxxxxxx>, Naoya Horiguchi <naoya.horiguchi@xxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Zack Rusin <zackr@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Axel Rasmussen <axelrasmussen@xxxxxxxxxx>, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>, Miaohe Lin <linmiaohe@xxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Thomas Hellstrom <thomas.hellstrom@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <242721-1e64-845e-226a-bf2b2dc72dd@google.com>
References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> <242721-1e64-845e-226a-bf2b2dc72dd@google.com>

On Sun, May 21, 2023 at 11:19 PM Hugh Dickins <hughd@xxxxxxxxxx> wrote:
>
> MGLRU's walk_pte_range() use the safer pte_offset_map_nolock(), rather
> than pte_lockptr(), to get the ptl for its trylock.  Just return false
> and move on to next extent if it fails, like when the trylock fails.
> Remove the VM_WARN_ON_ONCE(pmd_leaf) since that will happen, rarely.
>
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>

Acked-by: Yu Zhao <yuzhao@xxxxxxxxxx>

References:
- [PATCH 00/31] mm: allow pte_offset_map[_lock]() to fail
  - From: Hugh Dickins
- [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail
  - From: Hugh Dickins

Prev by Date: [PATCH 29/31] mm/memory: handle_pte_fault() use pte_offset_map_nolock()
Next by Date: [PATCH 30/31] mm/pgtable: delete pmd_trans_unstable() and friends
Previous by thread: [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail
Next by thread: [PATCH 24/31] mm/migrate_device: allow pte_offset_map_lock() to fail
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]