On 05/16/23 at 11:29pm, Christoph Hellwig wrote: > On Mon, May 15, 2023 at 05:08:35PM +0800, Baoquan He wrote: > > From: Christophe Leroy <christophe.leroy@xxxxxxxxxx> > > > > Define a generic version of ioremap_prot() and iounmap() that > > architectures can call after they have performed the necessary > > alteration to parameters and/or necessary verifications. > > > > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx> > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > --- > > include/asm-generic/io.h | 4 ++++ > > mm/ioremap.c | 22 ++++++++++++++++------ > > 2 files changed, 20 insertions(+), 6 deletions(-) > > > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > > index 587e7e9b9a37..a7ca2099ba19 100644 > > --- a/include/asm-generic/io.h > > +++ b/include/asm-generic/io.h > > @@ -1073,9 +1073,13 @@ static inline bool iounmap_allowed(void *addr) > > } > > #endif > > > > +void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size, > > + pgprot_t prot); > > + > > Formatting looks a bit weird here. The normal styles are either to > indent with two tabs (my preference) or after the opening brace. Thanks a lot for careful reviewing on this series. I check this place again, strange it looks good in code with identing after the opening brace, while in patch it looks messy. Will try again to see if I can fix it in patch too.
