On 05/03/2012 09:24 PM, Minchan Kim wrote: > On 05/04/2012 12:23 AM, Seth Jennings wrote: >> The reason I hadn't done it before is that it introduces a checkpatch >> warning: >> >> WARNING: do not add new typedefs >> #303: FILE: drivers/staging/zsmalloc/zsmalloc.h:19: >> +typedef void * zs_handle; >> > > > Yes. I did it but I think we are (a) of chapter 5: Typedefs in Documentation/CodingStyle. > > (a) totally opaque objects (where the typedef is actively used to _hide_ > what the object is). > > No? Interesting, seems like checkpatch and CodingStyle aren't completely in sync here. Maybe the warning should say "do not add new typedefs unless allowed by CodingStyle 5(a)" or something. Works for me though. Thanks again Minchan! -- Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>