On Wed, May 10, 2023 at 10:47 AM Rick Wertenbroek <rick.wertenbroek@xxxxxxxxx> wrote: > > The format string has a typo and prints e.g., > "Misaligned __add_pages start: 0xfc605 end: #fc609" instead > of "Misaligned __add_pages start: 0xfc605 end: 0xfc609" > Fix "#%lx" => "%#lx" > > Signed-off-by: Rick Wertenbroek <rick.wertenbroek@xxxxxxxxx> The issue appears in the __remove_pages format string as well, sorry didn't notice that right away. I'll send a new patch. Rick > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..446abb088b51 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > } > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1); > return -EINVAL; > } > > -- > 2.25.1 >