2023-05-04 6:06 GMT+09:00, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>: > On Wed, 3 May 2023 11:16:02 +0700 Bagas Sanjaya <bagasdotme@xxxxxxxxx> > wrote: > >> On Fri, Apr 07, 2023 at 07:44:33PM +0000, Danila Chernetsov wrote: >> > In ntfs_mft_data_extend_allocation_nolock(), if an error condition >> > occurs >> > prior to 'ctx' being set to a non-NULL value, avoid dereferencing the >> > NULL >> > 'ctx' pointer in error handling. >> > >> > Found by Linux Verification Center (linuxtesting.org) with SVACE. >> >> Duplicate of 10-years-old outstanding patch at [1]. > > Well, the patches are actually quite different. Is Danila's longer one > better? Danila's patch is better than old one. old patch doesn't free allocated cluster in error handling. And Christian will apply this to his queue if you drop this patch. > >> I'm not speaking of the patch itself but rather on unfortunate state >> of ntfs subsystem. It seems like the maintainer is MIA (has not >> responding to patch submissions for a long time). Some trivial >> patches, however, are merged through mm tree. >> >> Konstantin (from newer ntfs3 subsystem), Andrew, would you like to take a >> look on this orphaned subsystem (and help reviewing)? I'd like to send >> MAINTAINERS update if it turns out to be the case. >> > > Sure, I can join linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx and hendle things > which come along. > > Or Christian may want to do that? > >> >> [1]: >> https://lore.kernel.org/all/1358389709-20561-1-git-send-email-nickolai@xxxxxxxxxxxxx/ > > >
