On Fri, Apr 28, 2023 at 2:44 AM Michal Hocko <mhocko@xxxxxxxx> wrote: > > On Thu 27-04-23 15:12:46, Yosry Ahmed wrote: > [...] > > However, I still think this change is valuable. Like you mentioned, > > the OOM log is not set in stone, but we shouldn't just change it for > > no reason. In this case, for cgroup v1 users, the OOM log changed for > > no reason beyond a side effect of another patch. Upon upgrading our > > kernel we noticed the behavior change. This patch restores the old > > behavior without any cost really, and it makes the code a tiny bit > > more consistent. > > Fair enough. Just make sure you go into more details about why this is > causing problems/inconveniences. I am slightly worried this might cause > problems to other people who would like to have the same report for both > v1 and v2 so we should at least have some solid argumetns to revert > rather than "it used has changed and we liked it more that way". > > I personally do not care all that much. It kinda sucks to dump counters > that are not tracked or fully tracked in v1 because that can mislead > people and that would be a bigger problem from my POV. Great point, let me send a v2 rephrasing the commit log of this patch and adding the Ack's on the first one. Thanks Michal! > -- > Michal Hocko > SUSE Labs
