On Thu, Mar 16, 2023 at 11:38:47AM -0700, Isaac Manjarres wrote: > On Sun, Nov 06, 2022 at 10:01:30PM +0000, Catalin Marinas wrote: > > Patches 7-12 change some ARCH_KMALLOC_MINALIGN uses to > > ARCH_DMA_MINALIGN. The crypto changes have been rejected by Herbert > > previously but I still included them here until the crypto code is > > refactored. > > Herbert merged the changes to the crypto code that were required to be > able to safely lower the minimum alignment for kmalloc in [1]. Yes, I saw this. > Given this, I don't think there's anything blocking this series from > being merged. The requirement for SWIOTLB to get to the minimum > kmalloc alignment down to 8 bytes shouldn't prevent this series from > being merged, as the amount of memory that is allocated for SWIOTLB > can be configured through the commandline to minimize the impact of > having SWIOTLB memory. Additionally, even if no SWIOTLB is present, > this series still offers memory savings on a lot of ARM64 platforms > by using the cache line size as the minimum alignment for kmalloc. Actually, there's some progress on the swiotlb front to allow dynamic allocation. I haven't reviewed the series yet (I wasn't aware of it until v2) but at a quick look, it limits the dynamic allocation to bouncing buffers of at least a page size. Maybe this can be later improved for buffers below ARCH_DMA_MINALIGN. https://lore.kernel.org/r/cover.1681898595.git.petr.tesarik.ext@xxxxxxxxxx > Can you please rebase this series so that it can be merged? I rebased it locally but the last stumbling block is sorting out the iommu bouncing. I was hoping Robin Murphy can lend a hand but he's been busy with other bits. I'll repost the series at 6.4-rc1. -- Catalin
